Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bucket ACL error #160

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Fix bucket ACL error #160

merged 5 commits into from
Apr 11, 2023

Conversation

zack-is-cool
Copy link
Member

closes #159

@zack-is-cool zack-is-cool requested a review from a team as a code owner April 11, 2023 17:24
RothAndrew
RothAndrew reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@RothAndrew RothAndrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(moving my comment over from the other PR)

Do we want to delete the depends_on in the public access block? It got added to try to fix this issue but it obviously didn't work since the issue still happens.

@zack-is-cool
Copy link
Member Author

(moving my comment over from the other PR)

Do we want to delete the depends_on in the public access block? It got added to try to fix this issue but it obviously didn't work since the issue still happens.

Sure. I just made those changes.

@RothAndrew
Copy link
Member

/test all

1 similar comment
@zack-is-cool
Copy link
Member Author

/test all

@RothAndrew
Copy link
Member

Got the "empty output" error, rerunning the test

@RothAndrew
Copy link
Member

/test all

@zack-is-cool
Copy link
Member Author

/test all

@zack-is-cool
Copy link
Member Author

I tried adding a bunch of depends_on logic found here to the bastion s3 resource stuff.
https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/blob/master/main.tf

@RothAndrew RothAndrew enabled auto-merge (squash) April 11, 2023 22:03
@RothAndrew RothAndrew changed the title fix bucket acl error Fix bucket ACL error Apr 11, 2023
@RothAndrew RothAndrew merged commit 902ea3a into main Apr 11, 2023
@RothAndrew RothAndrew deleted the bug/fix-bucket-acl branch April 11, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RothAndrew RothAndrew RothAndrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error - cannot create bucket acl
2 participants
@zack-is-cool @RothAndrew